fix(ui-server-auth): clarify social-only email sign-in hint#1879
Open
lulu0119 wants to merge 1 commit into
Open
fix(ui-server-auth): clarify social-only email sign-in hint#1879lulu0119 wants to merge 1 commit into
lulu0119 wants to merge 1 commit into
Conversation
Replace the misleading authFailed message when check-email finds an existing social account without a password. Add socialOnlyNoPassword copy (zh-Hans/zh-Hant localized; other locales use English pending community translations) and widen the sign-in error banner slightly. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.
Hey, maintainers, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏 |
Member
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authFailedcopy on the sign-in identify step whencheck-emailfinds an existing Google/GitHub-only account (no password credential).server.auth.signIn.error.socialOnlyNoPasswordwith localized zh-Hans / zh-Hant strings; ja/ko/es/fr/ru/vi temporarily use the English text for community follow-up.max-w-xstomax-w-smso the hint wraps more cleanly.Test plan
pnpm -F @proj-airi/ui-server-auth build(if testing viaapps/serveron:3000)/auth/sign-in, enter an email registered with Google/GitHub only → seesocialOnlyNoPasswordhint (not “Authentication failed”)Made with Cursor